Skip to content

Add color extraction from pictures.#3409

Merged
ildyria merged 3 commits intomasterfrom
color-extraction
Jun 7, 2025
Merged

Add color extraction from pictures.#3409
ildyria merged 3 commits intomasterfrom
color-extraction

Conversation

@ildyria
Copy link
Copy Markdown
Member

@ildyria ildyria commented Jun 3, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2025

Codecov Report

Attention: Patch coverage is 68.18182% with 63 lines in your changes missing coverage. Please review.

Project coverage is 86.69%. Comparing base (5cc875e) to head (002d201).
Report is 1 commits behind head on master.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ildyria ildyria force-pushed the color-extraction branch from 138d952 to f9bd1a7 Compare June 5, 2025 07:35
@ildyria ildyria force-pushed the color-extraction branch from 495ff23 to 5681a0e Compare June 5, 2025 20:08
@ildyria ildyria marked this pull request as ready for review June 6, 2025 17:25
@ildyria ildyria requested a review from a team as a code owner June 6, 2025 17:25
@ildyria ildyria added the Review: easy Easy review expected: probably just need a quick to go through. label Jun 6, 2025
@ildyria ildyria changed the title 🚧 Add color extraction from pictures. Add color extraction from pictures. Jun 6, 2025
Comment thread app/Models/Palette.php Outdated
];

/**
* @return array{colour_1:string,colour_2:string,colour_3:string,colour_4:string,colour_5:string}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the background behind 5 colors for the color palette?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sancsin what do you mean ? :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a stacked PR so I added all the functionalities on top of each other. :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ildyria ildyria merged commit 4b25328 into master Jun 7, 2025
35 checks passed
@ildyria ildyria deleted the color-extraction branch June 7, 2025 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review: easy Easy review expected: probably just need a quick to go through.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants